farcasclaudiu/Flowise
1
0
Fork 0
mirror of https://github.com/farcasclaudiu/Flowise.git synced 2026-06-22 07:01:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix/Refactor createFileAttachment to streamline chatId validation (#4740)

Browse Source 
Removed redundant chatId validation and path traversal checks, improving code clarity and maintainability. The chatId is now validated after the chatflowid check, ensuring proper error handling for invalid inputs.
This commit is contained in:
Henry Heng
2025-06-26 16:14:04 +01:00
committed by GitHub
parent e7553a1c4e
commit e326bc8f49
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/utils/createAttachment.ts
+3 -8
View File
@@ -30,17 +30,12 @@ export const createFileAttachment = async (req: Request) => {
if (!chatflowid || !isValidUUID(chatflowid)) {
throw new InternalFlowiseError(StatusCodes.BAD_REQUEST, 'Invalid chatflowId format - must be a valid UUID')
}
const chatId = req.params.chatId
if (!chatId || !isValidUUID(chatId)) {
throw new InternalFlowiseError(StatusCodes.BAD_REQUEST, 'Invalid chatId format - must be a valid UUID')
}
// Check for path traversal attempts
if (isPathTraversal(chatflowid) || isPathTraversal(chatId)) {
if (isPathTraversal(chatflowid)) {
throw new InternalFlowiseError(StatusCodes.BAD_REQUEST, 'Invalid path characters detected')
}
const chatId = req.params.chatId
// Validate chatflow exists and check API key
const chatflow = await appServer.AppDataSource.getRepository(ChatFlow).findOneBy({
id: chatflowid