mirror of
https://github.com/farcasclaudiu/xtb-investment-tools.git
synced 2026-06-22 07:01:58 +03:00
Enhance portfolio review skill to conditionally generate CSV exports and update documentation for clarity
This commit is contained in:
@@ -16,7 +16,8 @@ Use this skill to run and assess XTB portfolio reviews from a copied skill folde
|
||||
`<skill-folder>/scripts/validate-review.sh`
|
||||
4. Generate the review from the directory where outputs should be written:
|
||||
`<skill-folder>/scripts/run-review.sh <report.xlsx>`
|
||||
5. Inspect `results/` outputs named from the workbook stem, especially `_review.html`, `_holdings.csv`, `_cash_flows.csv`, `_performance.csv`, `_income.csv`, and `_evolution.csv`.
|
||||
Add `--csv` only when the user explicitly asks for CSV exports.
|
||||
5. Inspect the `results/<stem>_review.html` output. If CSV export was requested, also inspect outputs named from the workbook stem, especially `_holdings.csv`, `_cash_flows.csv`, `_performance.csv`, `_income.csv`, and `_evolution.csv`.
|
||||
6. Check whether computed ending cash reconciles to the broker `Total` row within EUR/USD/etc. `0.01`.
|
||||
7. Report findings with caveats: cost-priced tickers, missing live prices, cash mismatch, XIRR availability, concentration, income tax drag, and any generated file paths.
|
||||
|
||||
@@ -25,7 +26,7 @@ Use this skill to run and assess XTB portfolio reviews from a copied skill folde
|
||||
- `scripts/main.py`: standalone XTB portfolio review generator.
|
||||
- `scripts/html_charts.py`: offline Chart.js report rendering helper.
|
||||
- `scripts/assets/chartjs.umd.min.js`: vendored Chart.js bundle for self-contained HTML.
|
||||
- `scripts/run-review.sh`: shell wrapper that runs the bundled review tool with `--csv`.
|
||||
- `scripts/run-review.sh`: shell wrapper that runs the bundled review tool. It writes only the HTML report by default; pass `--csv` to also write CSV outputs.
|
||||
- `scripts/validate-review.sh`: dependency and asset smoke check.
|
||||
- `scripts/setup-env.sh`: creates `.venv` in the current working directory and installs dependencies.
|
||||
- `scripts/requirements.txt`: Python dependencies.
|
||||
@@ -38,5 +39,5 @@ Use this skill to run and assess XTB portfolio reviews from a copied skill folde
|
||||
## Guardrails
|
||||
|
||||
- Do not treat the generated report as investment advice; describe what the tool computed and the data-quality limits.
|
||||
- Prefer the bundled validation script and generated CSVs over eyeballing the HTML alone.
|
||||
- Prefer the bundled validation script and generated outputs over eyeballing the HTML alone.
|
||||
- Preserve offline/self-contained HTML behavior; do not introduce CDN dependencies when modifying the report.
|
||||
|
||||
@@ -10,4 +10,4 @@ else
|
||||
PYTHON_BIN="python3"
|
||||
fi
|
||||
|
||||
exec "$PYTHON_BIN" "$SCRIPT_DIR/main.py" "$@" --csv
|
||||
exec "$PYTHON_BIN" "$SCRIPT_DIR/main.py" "$@"
|
||||
|
||||
Reference in New Issue
Block a user