removed deprecated lines

demo-10/cloudinit.tf

@@ -1,15 +1,18 @@
 provider "cloudinit" {}
 
-resource "template_file" "init-script" {
+data "template_file" "init-script" {
   template = "${file("scripts/init.cfg")}"
   vars {
-    region = "${var.AWS_REGION}"
+    REGION = "${var.AWS_REGION}"
   }
 }
-resource "template_file" "shell-script" {
+data "template_file" "shell-script" {
   template = "${file("scripts/volumes.sh")}"
+  vars {
+    DEVICE = "${var.INSTANCE_DEVICE_NAME}"
+  }
 }
-resource "template_cloudinit_config" "cloudinit-example" {
+data "template_cloudinit_config" "cloudinit-example" {
 
   gzip = false
   base64_encode = false
@@ -17,12 +20,12 @@ resource "template_cloudinit_config" "cloudinit-example" {
   part {
     filename     = "init.cfg"
     content_type = "text/cloud-config"
-    content      = "${template_file.init-script.rendered}"
+    content      = "${data.template_file.init-script.rendered}"
   }
 
   part {
     content_type = "text/x-shellscript"
-    content      = "${template_file.shell-script.rendered}"
+    content      = "${data.template_file.shell-script.rendered}"
   }
 
 }

demo-10/instance.tf

@@ -22,7 +22,7 @@ resource "aws_ebs_volume" "ebs-volume-1" {
 }
 
 resource "aws_volume_attachment" "ebs-volume-1-attachment" {
-  device_name = "/dev/xvdh"
+  device_name = "${var.INSTANCE_DEVICE_NAME}"
   volume_id = "${aws_ebs_volume.ebs-volume-1.id}"
   instance_id = "${aws_instance.example.id}"
 }

demo-10/scripts/volumes.sh

@@ -2,8 +2,6 @@
 
 vgchange -ay
 
-DEVICE="/dev/xvdh"
-
 DEVICE_FS=`blkid -o value -s TYPE ${DEVICE}`
 exit 0
 pvcreate ${DEVICE}

demo-10/vars.tf

@@ -15,3 +15,6 @@ variable "AMIS" {
     eu-west-1 = "ami-844e0bf7"
   }
 }
+variable "INSTANCE_DEVICE_NAME" {
+  default = "/dev/xvdh"
+}