perf: use .abort.bind() instead of arrow closures to prevent memory leaks (#7174)

src/agents/model-scan.ts

@@ -185,7 +185,7 @@ async function withTimeout<T>(
   fn: (signal: AbortSignal) => Promise<T>,
 ): Promise<T> {
   const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
+  const timer = setTimeout(controller.abort.bind(controller), timeoutMs);
   try {
     return await fn(controller.signal);
   } finally {

src/agents/pi-tools.abort.ts

@@ -36,7 +36,7 @@ function combineAbortSignals(a?: AbortSignal, b?: AbortSignal): AbortSignal | un
   }
 
   const controller = new AbortController();
-  const onAbort = () => controller.abort();
+  const onAbort = controller.abort.bind(controller);
   a?.addEventListener("abort", onAbort, { once: true });
   b?.addEventListener("abort", onAbort, { once: true });
   return controller.signal;

src/agents/sandbox/browser.ts

@@ -24,7 +24,7 @@ async function waitForSandboxCdp(params: { cdpPort: number; timeoutMs: number })
   while (Date.now() < deadline) {
     try {
       const ctrl = new AbortController();
-      const t = setTimeout(() => ctrl.abort(), 1000);
+      const t = setTimeout(ctrl.abort.bind(ctrl), 1000);
       try {
         const res = await fetch(url, { signal: ctrl.signal });
         if (res.ok) {

src/agents/tools/web-shared.ts

@@ -65,7 +65,7 @@ export function withTimeout(signal: AbortSignal | undefined, timeoutMs: number):
     return signal ?? new AbortController().signal;
   }
   const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
+  const timer = setTimeout(controller.abort.bind(controller), timeoutMs);
   if (signal) {
     signal.addEventListener(
       "abort",

src/browser/cdp.helpers.ts

@@ -114,7 +114,7 @@ function createCdpSender(ws: WebSocket) {
 
 export async function fetchJson<T>(url: string, timeoutMs = 1500, init?: RequestInit): Promise<T> {
   const ctrl = new AbortController();
-  const t = setTimeout(() => ctrl.abort(), timeoutMs);
+  const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
   try {
     const headers = getHeadersWithAuth(url, (init?.headers as Record<string, string>) || {});
     const res = await fetch(url, { ...init, headers, signal: ctrl.signal });
@@ -129,7 +129,7 @@ export async function fetchJson<T>(url: string, timeoutMs = 1500, init?: Request
 
 export async function fetchOk(url: string, timeoutMs = 1500, init?: RequestInit): Promise<void> {
   const ctrl = new AbortController();
-  const t = setTimeout(() => ctrl.abort(), timeoutMs);
+  const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
   try {
     const headers = getHeadersWithAuth(url, (init?.headers as Record<string, string>) || {});
     const res = await fetch(url, { ...init, headers, signal: ctrl.signal });

src/browser/chrome.ts

@@ -80,7 +80,7 @@ type ChromeVersion = {
 
 async function fetchChromeVersion(cdpUrl: string, timeoutMs = 500): Promise<ChromeVersion | null> {
   const ctrl = new AbortController();
-  const t = setTimeout(() => ctrl.abort(), timeoutMs);
+  const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
   try {
     const versionUrl = appendCdpPath(cdpUrl, "/json/version");
     const res = await fetch(versionUrl, {

src/browser/server-context.ts

@@ -51,7 +51,7 @@ function normalizeWsUrl(raw: string | undefined, cdpBaseUrl: string): string | u
 
 async function fetchJson<T>(url: string, timeoutMs = 1500, init?: RequestInit): Promise<T> {
   const ctrl = new AbortController();
-  const t = setTimeout(() => ctrl.abort(), timeoutMs);
+  const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
   try {
     const headers = getHeadersWithAuth(url, (init?.headers as Record<string, string>) || {});
     const res = await fetch(url, { ...init, headers, signal: ctrl.signal });
@@ -66,7 +66,7 @@ async function fetchJson<T>(url: string, timeoutMs = 1500, init?: RequestInit):
 
 async function fetchOk(url: string, timeoutMs = 1500, init?: RequestInit): Promise<void> {
   const ctrl = new AbortController();
-  const t = setTimeout(() => ctrl.abort(), timeoutMs);
+  const t = setTimeout(ctrl.abort.bind(ctrl), timeoutMs);
   try {
     const headers = getHeadersWithAuth(url, (init?.headers as Record<string, string>) || {});
     const res = await fetch(url, { ...init, headers, signal: ctrl.signal });

src/infra/fetch.ts

@@ -42,7 +42,7 @@ export function wrapFetchWithAbortSignal(fetchImpl: typeof fetch): typeof fetch
       return fetchImpl(input, patchedInit);
     }
     const controller = new AbortController();
-    const onAbort = () => controller.abort();
+    const onAbort = controller.abort.bind(controller);
     if (signal.aborted) {
       controller.abort();
     } else {

src/infra/net/fetch-guard.ts

@@ -50,8 +50,8 @@ function buildAbortSignal(params: { timeoutMs?: number; signal?: AbortSignal }):
   }
 
   const controller = new AbortController();
-  const timeoutId = setTimeout(() => controller.abort(), timeoutMs);
+  const timeoutId = setTimeout(controller.abort.bind(controller), timeoutMs);
-  const onAbort = () => controller.abort();
+  const onAbort = controller.abort.bind(controller);
   if (signal) {
     if (signal.aborted) {
       controller.abort();

src/infra/provider-usage.fetch.shared.ts

@@ -5,7 +5,7 @@ export async function fetchJson(
   fetchFn: typeof fetch,
 ): Promise<Response> {
   const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
+  const timer = setTimeout(controller.abort.bind(controller), timeoutMs);
   try {
     return await fetchFn(url, { ...init, signal: controller.signal });
   } finally {

src/tts/tts.ts

@@ -937,7 +937,7 @@ async function summarizeText(params: {
 
   try {
     const controller = new AbortController();
-    const timeout = setTimeout(() => controller.abort(), timeoutMs);
+    const timeout = setTimeout(controller.abort.bind(controller), timeoutMs);
 
     try {
       const res = await completeSimple(
@@ -1038,7 +1038,7 @@ async function elevenLabsTTS(params: {
   const normalizedSeed = normalizeSeed(seed);
 
   const controller = new AbortController();
-  const timeout = setTimeout(() => controller.abort(), timeoutMs);
+  const timeout = setTimeout(controller.abort.bind(controller), timeoutMs);
 
   try {
     const url = new URL(`${normalizeElevenLabsBaseUrl(baseUrl)}/v1/text-to-speech/${voiceId}`);
@@ -1098,7 +1098,7 @@ async function openaiTTS(params: {
   }
 
   const controller = new AbortController();
-  const timeout = setTimeout(() => controller.abort(), timeoutMs);
+  const timeout = setTimeout(controller.abort.bind(controller), timeoutMs);
 
   try {
     const response = await fetch(`${getOpenAITtsBaseUrl()}/audio/speech`, {

src/utils/fetch-timeout.ts

@@ -15,7 +15,7 @@ export async function fetchWithTimeout(
   fetchFn: typeof fetch = fetch,
 ): Promise<Response> {
   const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), Math.max(1, timeoutMs));
+  const timer = setTimeout(controller.abort.bind(controller), Math.max(1, timeoutMs));
   try {
     return await fetchFn(url, { ...init, signal: controller.signal });
   } finally {