farcasclaudiu/openclaw
1
0
Fork 0
mirror of https://github.com/farcasclaudiu/openclaw.git synced 2026-06-28 15:01:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe googlechat webhook routing setup

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-15 00:22:52 +00:00
parent 54060104a7
commit be57344b99
1 changed files with 39 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/googlechat/src/monitor.webhook-routing.test.ts
+39 -50
View File
@@ -63,33 +63,46 @@ const baseAccount = (accountId: string) =>
config: {}, config: {},
}) as ResolvedGoogleChatAccount; }) as ResolvedGoogleChatAccount;
function registerTwoTargets() {
const sinkA = vi.fn();
const sinkB = vi.fn();
const core = {} as PluginRuntime;
const config = {} as OpenClawConfig;
const unregisterA = registerGoogleChatWebhookTarget({
account: baseAccount("A"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkA,
mediaMaxMb: 5,
});
const unregisterB = registerGoogleChatWebhookTarget({
account: baseAccount("B"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkB,
mediaMaxMb: 5,
});
return {
sinkA,
sinkB,
unregister: () => {
unregisterA();
unregisterB();
},
};
}
describe("Google Chat webhook routing", () => { describe("Google Chat webhook routing", () => {
it("rejects ambiguous routing when multiple targets on the same path verify successfully", async () => { it("rejects ambiguous routing when multiple targets on the same path verify successfully", async () => {
vi.mocked(verifyGoogleChatRequest).mockResolvedValue({ ok: true }); vi.mocked(verifyGoogleChatRequest).mockResolvedValue({ ok: true });
const sinkA = vi.fn(); const { sinkA, sinkB, unregister } = registerTwoTargets();
const sinkB = vi.fn();
const core = {} as PluginRuntime;
const config = {} as OpenClawConfig;
const unregisterA = registerGoogleChatWebhookTarget({
account: baseAccount("A"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkA,
mediaMaxMb: 5,
});
const unregisterB = registerGoogleChatWebhookTarget({
account: baseAccount("B"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkB,
mediaMaxMb: 5,
});
try { try {
const res = createWebhookResponse(); const res = createWebhookResponse();
@@ -106,8 +119,7 @@ describe("Google Chat webhook routing", () => {
expect(sinkA).not.toHaveBeenCalled(); expect(sinkA).not.toHaveBeenCalled();
expect(sinkB).not.toHaveBeenCalled(); expect(sinkB).not.toHaveBeenCalled();
} finally { } finally {
unregisterA(); unregister();
unregisterB();
} }
}); });
@@ -116,29 +128,7 @@ describe("Google Chat webhook routing", () => {
.mockResolvedValueOnce({ ok: false, reason: "invalid" }) .mockResolvedValueOnce({ ok: false, reason: "invalid" })
.mockResolvedValueOnce({ ok: true }); .mockResolvedValueOnce({ ok: true });
const sinkA = vi.fn(); const { sinkA, sinkB, unregister } = registerTwoTargets();
const sinkB = vi.fn();
const core = {} as PluginRuntime;
const config = {} as OpenClawConfig;
const unregisterA = registerGoogleChatWebhookTarget({
account: baseAccount("A"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkA,
mediaMaxMb: 5,
});
const unregisterB = registerGoogleChatWebhookTarget({
account: baseAccount("B"),
config,
runtime: {},
core,
path: "/googlechat",
statusSink: sinkB,
mediaMaxMb: 5,
});
try { try {
const res = createWebhookResponse(); const res = createWebhookResponse();
@@ -155,8 +145,7 @@ describe("Google Chat webhook routing", () => {
expect(sinkA).not.toHaveBeenCalled(); expect(sinkA).not.toHaveBeenCalled();
expect(sinkB).toHaveBeenCalledTimes(1); expect(sinkB).toHaveBeenCalledTimes(1);
} finally { } finally {
unregisterA(); unregister();
unregisterB();
} }
}); });
}); });