mirror of https://github.com/farcasclaudiu/TradingAgents.git synced 2026-06-22 07:01:21 +03:00

Files

T

javierdejesusda f5026009f9 fix(llm_clients): standardize Google API key to unified api_key param

GoogleClient now accepts the unified `api_key` parameter used by
OpenAI and Anthropic clients, mapping it to the provider-specific
`google_api_key` that ChatGoogleGenerativeAI expects. Legacy
`google_api_key` still works for backward compatibility.

Resolves TODO.md item #2 (inconsistent parameter handling).

2026-03-24 14:35:02 +01:00

766 B

Raw Blame History

LLM Clients - Consistency Improvements

Issues to Fix

1. `validate_model()` is never called

Add validation call in get_llm() with warning (not error) for unknown models

2. Inconsistent parameter handling (Fixed)

GoogleClient now accepts unified api_key and maps it to google_api_key
Legacy google_api_key still works for backward compatibility

3. `base_url` accepted but ignored

AnthropicClient: accepts base_url but never uses it
GoogleClient: accepts base_url but never uses it (correct - Google doesn't support it)

Fix: Remove unused base_url from clients that don't support it

4. Update validators.py with models from CLI

Sync VALID_MODELS dict with CLI model options after Feature 2 is complete

766 B Raw Blame History