farcasclaudiu/TradingAgents
1
0
Fork 0
mirror of https://github.com/farcasclaudiu/TradingAgents.git synced 2026-06-29 15:01:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: pass base_url to Google and Anthropic clients for proxy support (#427)

Browse Source
This commit is contained in:
Yijia-Xiao
2026-03-29 17:59:52 +00:00
parent 46e1b600b8
commit 58e99421bd
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tradingagents/llm_clients/TODO.md
+4 -8
View File
@@ -7,13 +7,9 @@
### 2. ~~Inconsistent parameter handling~~ (Fixed)
- GoogleClient now accepts unified `api_key` and maps it to `google_api_key`
- Legacy `google_api_key` still works for backward compatibility
### 3. `base_url` accepted but ignored
- `AnthropicClient`: accepts `base_url` but never uses it
- `GoogleClient`: accepts `base_url` but never uses it (correct - Google doesn't support it)
### 3. ~~`base_url` accepted but ignored~~ (Fixed)
- All clients now pass `base_url` to their respective LLM constructors
**Fix:** Remove unused `base_url` from clients that don't support it
### 4. Update validators.py with models from CLI
- Sync `VALID_MODELS` dict with CLI model options after Feature 2 is complete
### 4. ~~Update validators.py with models from CLI~~ (Fixed)
- Synced in v0.2.2