From aea2801b8cf2c160873aabb8b1e9808e395718d7 Mon Sep 17 00:00:00 2001 From: Rick Ryan Date: Wed, 9 Jul 2025 10:18:18 +0100 Subject: [PATCH] fix(components): promise.all failed silently when loading MCP tools (#4750) * fix(components): promise.all failed silently when loading MCP tools * fix: satisfy linter format * fix(packages): pnpm lint-fix * Update core.ts --------- Co-authored-by: Henry Heng --- packages/components/nodes/tools/MCP/core.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/components/nodes/tools/MCP/core.ts b/packages/components/nodes/tools/MCP/core.ts index 29ef381b..6c6f49f2 100644 --- a/packages/components/nodes/tools/MCP/core.ts +++ b/packages/components/nodes/tools/MCP/core.ts @@ -111,7 +111,13 @@ export class MCPToolkit extends BaseToolkit { argsSchema: createSchemaModel(tool.inputSchema) }) }) - return Promise.all(toolsPromises) + const res = await Promise.allSettled(toolsPromises) + const errors = res.filter((r) => r.status === 'rejected') + if (errors.length !== 0) { + console.error('MCP Tools falied to be resolved', errors) + } + const successes = res.filter((r) => r.status === 'fulfilled').map((r) => r.value) + return successes } }