Chore/Enhance file upload functionality in createAttachment (#5280)

Enhance file upload functionality in createAttachment

- Added support for configurable allowed file types and file upload status in createFileAttachment.
- Implemented validation to ensure uploaded files match allowed types, throwing errors for disallowed types.
This commit is contained in:
Henry Heng
2025-10-06 11:13:08 +01:00
committed by GitHub
parent 7a50755546
commit 1a410d84ac
2 changed files with 39 additions and 7 deletions
+38 -6
View File
@@ -75,23 +75,40 @@ export const createFileAttachment = async (req: Request) => {
usage: 'perPage', usage: 'perPage',
legacyBuild: false legacyBuild: false
} }
let allowedFileTypes: string[] = []
let fileUploadEnabled = false
if (chatflow.chatbotConfig) { if (chatflow.chatbotConfig) {
try { try {
const chatbotConfig = JSON.parse(chatflow.chatbotConfig) const chatbotConfig = JSON.parse(chatflow.chatbotConfig)
if (chatbotConfig?.fullFileUpload?.pdfFile) { if (chatbotConfig?.fullFileUpload) {
if (chatbotConfig.fullFileUpload.pdfFile.usage) { fileUploadEnabled = chatbotConfig.fullFileUpload.status
pdfConfig.usage = chatbotConfig.fullFileUpload.pdfFile.usage
// Get allowed file types from configuration
if (chatbotConfig.fullFileUpload.allowedUploadFileTypes) {
allowedFileTypes = chatbotConfig.fullFileUpload.allowedUploadFileTypes.split(',')
} }
if (chatbotConfig.fullFileUpload.pdfFile.legacyBuild !== undefined) {
pdfConfig.legacyBuild = chatbotConfig.fullFileUpload.pdfFile.legacyBuild // PDF specific configuration
if (chatbotConfig.fullFileUpload.pdfFile) {
if (chatbotConfig.fullFileUpload.pdfFile.usage) {
pdfConfig.usage = chatbotConfig.fullFileUpload.pdfFile.usage
}
if (chatbotConfig.fullFileUpload.pdfFile.legacyBuild !== undefined) {
pdfConfig.legacyBuild = chatbotConfig.fullFileUpload.pdfFile.legacyBuild
}
} }
} }
} catch (e) { } catch (e) {
// Use default PDF config if parsing fails // Use default config if parsing fails
} }
} }
// Check if file upload is enabled
if (!fileUploadEnabled) {
throw new InternalFlowiseError(StatusCodes.BAD_REQUEST, 'File upload is not enabled for this chatflow')
}
// Find FileLoader node // Find FileLoader node
const fileLoaderComponent = appServer.nodesPool.componentNodes['fileLoader'] const fileLoaderComponent = appServer.nodesPool.componentNodes['fileLoader']
const fileLoaderNodeInstanceFilePath = fileLoaderComponent.filePath as string const fileLoaderNodeInstanceFilePath = fileLoaderComponent.filePath as string
@@ -109,6 +126,21 @@ export const createFileAttachment = async (req: Request) => {
if (files.length) { if (files.length) {
const isBase64 = req.body.base64 const isBase64 = req.body.base64
for (const file of files) { for (const file of files) {
if (!allowedFileTypes.length) {
throw new InternalFlowiseError(
StatusCodes.BAD_REQUEST,
`File type '${file.mimetype}' is not allowed. Allowed types: ${allowedFileTypes.join(', ')}`
)
}
// Validate file type against allowed types
if (allowedFileTypes.length > 0 && !allowedFileTypes.includes(file.mimetype)) {
throw new InternalFlowiseError(
StatusCodes.BAD_REQUEST,
`File type '${file.mimetype}' is not allowed. Allowed types: ${allowedFileTypes.join(', ')}`
)
}
await checkStorage(orgId, subscriptionId, appServer.usageCacheManager) await checkStorage(orgId, subscriptionId, appServer.usageCacheManager)
const fileBuffer = await getFileFromUpload(file.path ?? file.key) const fileBuffer = await getFileFromUpload(file.path ?? file.key)
@@ -18,7 +18,7 @@ import useNotifier from '@/utils/useNotifier'
// API // API
import chatflowsApi from '@/api/chatflows' import chatflowsApi from '@/api/chatflows'
const message = `Uploaded files will be parsed as strings and sent to the LLM. If file upload is enabled on the Vector Store as well, this will override and take precedence. const message = `The full contents of uploaded files will be converted to text and sent to the Agent.
<br /> <br />
Refer <a href='https://docs.flowiseai.com/using-flowise/uploads#files' target='_blank'>docs</a> for more details.` Refer <a href='https://docs.flowiseai.com/using-flowise/uploads#files' target='_blank'>docs</a> for more details.`